Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): Make websocket's log on success be in Debug, not info (#2788) #21

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

czarcas7ic
Copy link
Member

This log is extreme noise in our current setup for all RPC's. I moved to Debug, but should be deleted imo.

This logging of requests/responses should come at a higher proxy level IMO, or have the request + response written elsewhere asynchronously.


PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments
  • Title follows the Conventional Commits spec

PR checklist

  • Tests written/updated
  • Changelog entry added in .changelog (we use unclog to manage our changelog)
  • Updated relevant documentation (docs/ or spec/) and code comments

…tbft#2788)

This log is extreme noise in our current setup for all RPC's. I moved to
Debug, but should be deleted imo.

This logging of requests/responses should come at a higher proxy level
IMO, or have the request + response written elsewhere asynchronously.

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
@czarcas7ic czarcas7ic added the S:backport/v24 backport to the osmo-v24/v0.37.4 branch label Apr 15, 2024
@czarcas7ic czarcas7ic merged commit 634d970 into osmo/v0.37.4 Apr 15, 2024
16 of 17 checks passed
czarcas7ic added a commit that referenced this pull request Apr 15, 2024
…g-noise

fix(rpc): Make websocket's log on success be in Debug, not info (cometbft#2788)
czarcas7ic added a commit that referenced this pull request May 10, 2024
…g-noise

fix(rpc): Make websocket's log on success be in Debug, not info (cometbft#2788)
PaddyMc pushed a commit that referenced this pull request Aug 19, 2024
…g-noise

fix(rpc): Make websocket's log on success be in Debug, not info (cometbft#2788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S:backport/v24 backport to the osmo-v24/v0.37.4 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants